[Instrumentation.AspNet] Fix metric http.server.duration always being zero #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
- Coverage 73.91% 71.11% -2.80%
==========================================
Files 267 13 -254
Lines 9615 277 -9338
==========================================
- Hits 7107 197 -6910
+ Misses 2508 80 -2428
Flags with carried forward coverage won't be shown. Click here to find out more.
|
utpilla
added
the
comp:instrumentation.aspnet
test/OpenTelemetry.Instrumentation.AspNet.Tests/HttpInMetricsListenerTests.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Nov 3, 2023
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Kielek
approved these changes
Nov 6, 2023
This was referenced Nov 10, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #1388 as mentioned by @vishweshbankwar.
Changes
onRequestStoppedCallbackis called.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes